Niklas Ye
f4ca0059dc
The web UI signs in with a username and password and holds a session cookie; the TUI was the only client still needing an API key pasted into a config file. It now asks for the same credentials on a form at start. What is kept between runs is the session token, not the password, in session.json under the config directory, mode 0600 and keyed by server URL so one server's token is never offered to another. It resumes on the next start; the server's sessions last 30 days and slide with use. L signs out, which ends the session on the server and deletes the saved one even if the server cannot be reached. The client attaches the cookie by hand instead of using a cookie jar: the server marks it Secure behind https, and a jar drops a Secure cookie it is given over plain http, which would break a local server for no reason. It sends no Authorization header at all, since the server judges a request carrying one on that alone and never falls back to the cookie. Writes go through the server's cross-origin guard, which lets a client that sends neither Origin nor Sec-Fetch-Site through; checked against a real v0.20.1 server for both reads and writes. A 401 from anything means the session is gone (expired, ended from the web UI, or the account disabled), so the TUI returns to the form with the reason, forgets the saved token, and drops what the last session loaded rather than showing it to whoever signs in next. A 403 is a permission and leaves the session alone. The refresh timer is started once, so signing out and in does not leave two running. An account with no password cannot sign in, and the server answers it exactly like a wrong password, so the form's message says a password must be set first. Users created only for API access hit this. Breaking: api_key in config.yaml is no longer used. It is not an error to leave it there; the form says it is ignored. API keys still exist on the server and k in Users still manages them.
93 lines
2.4 KiB
Go
93 lines
2.4 KiB
Go
package session
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func isolate(t *testing.T) {
|
|
t.Helper()
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
}
|
|
|
|
func TestSaveThenLoad(t *testing.T) {
|
|
isolate(t)
|
|
if got := Load("https://terdut.example.com"); got != "" {
|
|
t.Fatalf("expected no session yet, got %q", got)
|
|
}
|
|
if err := Save("https://terdut.example.com", "tok"); err != nil {
|
|
t.Fatalf("save: %v", err)
|
|
}
|
|
if got := Load("https://terdut.example.com"); got != "tok" {
|
|
t.Errorf("expected tok, got %q", got)
|
|
}
|
|
// A trailing slash is the same server.
|
|
if got := Load("https://terdut.example.com/"); got != "tok" {
|
|
t.Errorf("a trailing slash should not lose the session, got %q", got)
|
|
}
|
|
}
|
|
|
|
// A token is only ever valid for the server that issued it; offering it to a
|
|
// different one would send a credential to somebody it was never meant for.
|
|
func TestLoadIgnoresAnotherServersSession(t *testing.T) {
|
|
isolate(t)
|
|
if err := Save("https://a.example.com", "tok"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got := Load("https://b.example.com"); got != "" {
|
|
t.Errorf("a session for another server must not be reused, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestSaveIsOwnerOnly(t *testing.T) {
|
|
isolate(t)
|
|
if err := Save("https://a.example.com", "tok"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
p, _ := path()
|
|
info, err := os.Stat(p)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if perm := info.Mode().Perm(); perm != 0o600 {
|
|
t.Errorf("the session file holds a credential and must be 0600, got %o", perm)
|
|
}
|
|
entries, _ := os.ReadDir(filepath.Dir(p))
|
|
for _, e := range entries {
|
|
if e.Name() != "session.json" {
|
|
t.Errorf("a temporary file was left behind: %s", e.Name())
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestClear(t *testing.T) {
|
|
isolate(t)
|
|
if err := Clear(); err != nil {
|
|
t.Errorf("clearing nothing is not an error, got %v", err)
|
|
}
|
|
if err := Save("https://a.example.com", "tok"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := Clear(); err != nil {
|
|
t.Fatalf("clear: %v", err)
|
|
}
|
|
if got := Load("https://a.example.com"); got != "" {
|
|
t.Errorf("expected the session gone, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestLoadToleratesGarbage(t *testing.T) {
|
|
isolate(t)
|
|
p, _ := path()
|
|
if err := os.MkdirAll(filepath.Dir(p), 0o700); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.WriteFile(p, []byte("{not json"), 0o600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got := Load("https://a.example.com"); got != "" {
|
|
t.Errorf("an unreadable file means no session, got %q", got)
|
|
}
|
|
}
|