Niklas Ye
d6c0f7508c
Assigning an on-call week panicked with "index out of range [-1]" on an ordinary schedule. The index came from scheduleTable.Cursor(). The cursor is not ours. bubbles' SetRows clamps it down when rows shrink (`if m.cursor > len(rows)-1`) but never back up, so setting zero rows drives it to -1 and filling the table afterwards leaves it there -- -1 is not greater than len-1, so nothing corrects it. Every table in this package is rebuilt from empty exactly once, when the first WindowSizeMsg arrives before any fetch has returned, so every cursor started at -1 and stayed there until the user pressed up or down. Pressing a direction key first is why this was survivable at all. setRows restores the invariant the rest of the package already assumes: a table with rows has a usable cursor. Every rebuild goes through it. Five call sites also bounds-checked only the top of the range, and are now consistent with their siblings, which already had `i < 0 ||`. They were the same latent panic: deleting a schedule entry, deleting a user, editing a topic, opening the API key menu, and the week assignment that actually fired. The regression test deliberately never calls SetCursor. That is what the existing schedule tests do, and SetCursor clamps, which is exactly how this got past them. It drives the real order instead: size, then data, then keys. Also carries a gofmt pass, which is why untouched files appear in the diff. The move to git.ryuvia.com rewrote import paths without re-sorting them, and the new path sorts before github.com/charmbracelet/..., where the old one sorted after. go vet does not look at import order, so CI had nothing to say.
100 lines
3.0 KiB
Go
100 lines
3.0 KiB
Go
package tui
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"git.ryuvia.com/niklas/terdut-tui/internal/api"
|
|
"github.com/charmbracelet/lipgloss"
|
|
)
|
|
|
|
var (
|
|
colorPrimary = lipgloss.Color("69") // blue
|
|
colorMuted = lipgloss.Color("240") // gray
|
|
colorFiring = lipgloss.Color("196") // red
|
|
colorResolved = lipgloss.Color("70") // green
|
|
colorAccent = lipgloss.Color("214") // orange
|
|
|
|
colorSevCritical = lipgloss.Color("196") // red
|
|
colorSevError = lipgloss.Color("202") // dark orange
|
|
colorSevWarning = lipgloss.Color("214") // orange
|
|
colorSevInfo = lipgloss.Color("39") // cyan
|
|
|
|
styleHeader = lipgloss.NewStyle().
|
|
Bold(true).
|
|
Foreground(colorPrimary).
|
|
Padding(0, 1)
|
|
|
|
styleTabActive = lipgloss.NewStyle().
|
|
Bold(true).
|
|
Foreground(lipgloss.Color("0")).
|
|
Background(colorPrimary).
|
|
Padding(0, 2)
|
|
|
|
styleTabInactive = lipgloss.NewStyle().
|
|
Foreground(colorMuted).
|
|
Padding(0, 2)
|
|
|
|
styleFooter = lipgloss.NewStyle().
|
|
Foreground(colorMuted)
|
|
|
|
styleStatus = lipgloss.NewStyle().
|
|
Foreground(colorAccent).
|
|
Bold(true)
|
|
|
|
styleError = lipgloss.NewStyle().
|
|
Foreground(colorFiring).
|
|
Bold(true)
|
|
|
|
styleFiring = lipgloss.NewStyle().Foreground(colorFiring).Bold(true)
|
|
styleResolved = lipgloss.NewStyle().Foreground(colorResolved)
|
|
styleMuted = lipgloss.NewStyle().Foreground(colorMuted)
|
|
styleAlertName = lipgloss.NewStyle().Bold(true)
|
|
styleBold = lipgloss.NewStyle().Bold(true)
|
|
styleSelected = lipgloss.NewStyle().Foreground(colorPrimary).Bold(true)
|
|
styleAccent = lipgloss.NewStyle().Foreground(colorAccent)
|
|
|
|
// Incident status. Triggered is unclaimed work and reads as loudly as a
|
|
// firing alert; acknowledged means somebody has it.
|
|
styleTriggered = lipgloss.NewStyle().Foreground(colorFiring).Bold(true)
|
|
styleAcknowledged = lipgloss.NewStyle().Foreground(colorAccent).Bold(true)
|
|
styleSnoozed = lipgloss.NewStyle().Foreground(colorMuted).Italic(true)
|
|
|
|
// Severity, over the conventional Alertmanager label values.
|
|
styleSevCritical = lipgloss.NewStyle().Foreground(colorSevCritical).Bold(true)
|
|
styleSevError = lipgloss.NewStyle().Foreground(colorSevError).Bold(true)
|
|
styleSevWarning = lipgloss.NewStyle().Foreground(colorSevWarning)
|
|
styleSevInfo = lipgloss.NewStyle().Foreground(colorSevInfo)
|
|
)
|
|
|
|
// severityStyle picks the style for a severity label, falling back to muted for
|
|
// values this client does not recognise rather than dropping them.
|
|
func severityStyle(severity string) lipgloss.Style {
|
|
switch strings.ToLower(severity) {
|
|
case "critical":
|
|
return styleSevCritical
|
|
case "error":
|
|
return styleSevError
|
|
case "warning":
|
|
return styleSevWarning
|
|
case "info":
|
|
return styleSevInfo
|
|
default:
|
|
return styleMuted
|
|
}
|
|
}
|
|
|
|
// incidentStatusStyle picks the style for an incident status, falling back to
|
|
// muted for statuses added after this client was built.
|
|
func incidentStatusStyle(status string) lipgloss.Style {
|
|
switch status {
|
|
case api.StatusTriggered:
|
|
return styleTriggered
|
|
case api.StatusAcknowledged:
|
|
return styleAcknowledged
|
|
case api.StatusResolved:
|
|
return styleResolved
|
|
default:
|
|
return styleMuted
|
|
}
|
|
}
|