Fix Stats/Admin/Account showing in the bottom bar too #29

2026-10-03T07:22:59Z

niklas commented

2026-10-03 07:22:59 +00:00

Bug in v0.35.0's bottom-tab-bar change (#26/#28): .nav-link-secondary { display: none; } was declared before .nav-link { display: flex; ... } in app.css. Both are single-class selectors — equal specificity — so the tie is broken by source order, not by which classes an element carries, and .nav-link's later display: flex was winning for every element that had both classes. Result: Stats, Admin and Account rendered as extra tabs on the phone-width bottom bar in addition to being reachable through "More", which is the crowding reported against the release.

Fix: move the rule after .nav-link (no value changed, just order). Verified by diffing the served app.css from a local instance before/after.

Local gate (fmt lint test helm-lint) is green.

Bug in v0.35.0's bottom-tab-bar change (#26/#28): `.nav-link-secondary { display: none; }` was declared *before* `.nav-link { display: flex; ... }` in `app.css`. Both are single-class selectors — equal specificity — so the tie is broken by source order, not by which classes an element carries, and `.nav-link`'s later `display: flex` was winning for every element that had both classes. Result: Stats, Admin and Account rendered as extra tabs on the phone-width bottom bar in addition to being reachable through "More", which is the crowding reported against the release. Fix: move the rule after `.nav-link` (no value changed, just order). Verified by diffing the served `app.css` from a local instance before/after. Local gate (`fmt lint test helm-lint`) is green.

niklas added 1 commit 2026-10-03 07:23:00 +00:00

Fix Stats/Admin/Account showing in the bottom bar too

CI / chart (pull_request) Successful in 1s

Details

CI / security (pull_request) Successful in 16s

Details

CI / test (pull_request) Successful in 5m2s

Details

1770e5d945

.nav-link-secondary's display:none sat before .nav-link's own
display:flex in the file. Both are single-class selectors, so they tie
on specificity, and a tie is broken by which one comes later in the
file -- not by which class the element happens to carry. .nav-link's
declaration, being later, won for every element wearing both classes,
so Stats/Admin/Account rendered as three extra tabs on the phone bar
instead of folding into "More" as intended.

Moved the rule below .nav-link instead of changing either declaration,
since nothing about the values was wrong -- only their order was.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

niklas merged commit d9492913ed into main

2026-10-03 07:30:05 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: niklas/terdut-server#29